apurtell commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r471696078
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/NamedQueuePayload.java
##########
@@ -30,7 +30,8 @@
public class NamedQueuePayload {
public enum NamedQueueEvent {
- SLOW_LOG
+ SLOW_LOG,
Review comment:
I wish I had caught this earlier.
If we have to use an Enum here, add a constructor that defines an ordinal
for each type so we can maintain compatibility by instantiating by our ordinal,
e.g.
NamedQueueEvent(int ordinal) { ... }
SLOW_LOG(1),
BALANCE_DECISION(2),.
...
NamedQueueEvent getByOrdinal(int ordinal)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
