Apache9 commented on a change in pull request #2272:
URL: https://github.com/apache/hbase/pull/2272#discussion_r473790856
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java
##########
@@ -54,11 +56,15 @@ private static void moveToNextHour(Calendar calendar) {
public static int getCurrentHour() {
Tick tick = CurrentHourProvider.tick;
- if(System.currentTimeMillis() < tick.expirationTimeInMillis) {
+ if (EnvironmentEdgeManager.currentTime() < tick.expirationTimeInMillis) {
return tick.currentHour;
}
CurrentHourProvider.tick = tick = nextTick();
return tick.currentHour;
}
+
+ protected static void forceUpdateTickForTest() {
Review comment:
You can use any Collections you want. The point here, is that you can
inject multiple values at once, and also you can implement more complicated
logic in the currentTime method, so you do not need to add a
forceUpdateTickForTest method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
