Apache9 commented on a change in pull request #2272:
URL: https://github.com/apache/hbase/pull/2272#discussion_r473802512
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java
##########
@@ -54,11 +56,15 @@ private static void moveToNextHour(Calendar calendar) {
public static int getCurrentHour() {
Tick tick = CurrentHourProvider.tick;
- if(System.currentTimeMillis() < tick.expirationTimeInMillis) {
+ if (EnvironmentEdgeManager.currentTime() < tick.expirationTimeInMillis) {
return tick.currentHour;
}
CurrentHourProvider.tick = tick = nextTick();
return tick.currentHour;
}
+
+ protected static void forceUpdateTickForTest() {
Review comment:
Then just make the tick field as package private and add a
VisibleForTesting annotation? Just change it directly in UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
