[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267270#comment-13267270
]
Devaraj Das commented on HBASE-5732:
------------------------------------
bq. There is no corresponding remove of the /security directory. Should it be
included here?
Yeah, it shouldn't be there. However, I generated the patch with
--no-diff-deleted and hence these files still show up but if you download the
patch you will see a bunch of lines that say "Index: security/... (deleted)".
The person who commits needs to be aware of this I guess and run the
appropriate svn commands.
bq. I don't see you regenerating pb stuff after making these changes in this
proto file
There is actually - RPCProtos.java.
bq. What is this? Mistake?
(comment to do with the conf file change). I merged in the stuff from
hbase-site.xml from the security/src/test/resources into the src/test/resources
one since the security one would go away (yeah you won't know about it unless
you do a manual diff of the two hbase-site.xml files).
I am in the process of setting up a secure cluster etc. for some manual
testing.. Fingers crossed.
> Remove the SecureRPCEngine and merge the security-related logic in the core
> engine
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5732
> URL: https://issues.apache.org/jira/browse/HBASE-5732
> Project: HBase
> Issue Type: Improvement
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Attachments: rpcengine-merge.3.patch, rpcengine-merge.4.patch,
> rpcengine-merge.patch
>
>
> Remove the SecureRPCEngine and merge the security-related logic in the core
> engine. Follow up to HBASE-5727.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
