shahrs87 commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r478767046
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +968,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ private void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
+ if (!userRegionLock.tryLock(waitTime, TimeUnit.MILLISECONDS)) {
Review comment:
@bharathv @infraio Thank you for your feedback.
> Specifically I was wondering if hbase.client.operation.timeout would be
the right one to use for this.
I don't feel hbase.client.operation.timeout is the right choice here too.
This config is meant for the whole end to end operation timeout which includes
all layers of retries and the default value is 20 mins. If we use this timeout
then we are not gaining anything.
We can introduce a new config property (something like
hbase.client.lock.timeout.period) and default it to something like 10 seconds.
That way we don't depend on existing scanner/operation timeout periods. Let me
know what you guys think. Thank you !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
