saintstack commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r479460586
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +968,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ private void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
+ if (!userRegionLock.tryLock(waitTime, TimeUnit.MILLISECONDS)) {
Review comment:
Good concern @bharathv .
operation timeout is for 'whole operation end-to-end' per @shahrs87 . Here
we are doing a sub-task so operation timeout doesn't seem right. Scanner
timeout seems good; when it expires the scan will throw and we'll do the
finally block anyways?
What would you suggest @infraio ?
I agree w/ @apurtell that last thing we need is new timeout ; client timeout
is fraught as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
