Reidddddd commented on a change in pull request #2320:
URL: https://github.com/apache/hbase/pull/2320#discussion_r481599496
##########
File path:
hbase-asyncfs/src/test/java/org/apache/hadoop/hbase/security/HBaseKerberosUtils.java
##########
@@ -43,7 +43,9 @@
public static final String KRB_PRINCIPAL =
SecurityConstants.REGIONSERVER_KRB_PRINCIPAL;
public static final String MASTER_KRB_PRINCIPAL =
SecurityConstants.MASTER_KRB_PRINCIPAL;
public static final String KRB_KEYTAB_FILE =
SecurityConstants.REGIONSERVER_KRB_KEYTAB_FILE;
+ @Deprecated
public static final String CLIENT_PRINCIPAL =
AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL;
+ public static final String CLIENT_PRINCIPAL_VALUE =
AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL_VALUE;
Review comment:
I think there's no need to deprecate `CLIENT_PRINCIPAL` and methods
below, since it is a test class only. We can keep `CLIENT_PRINCIPAL` and
replace the value with the correct one. Same to the methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
