apurtell commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r482600399
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java ########## @@ -1673,4 +1682,13 @@ * @throws IOException if a remote or network exception occurs */ CompletableFuture<Void> updateRSGroupConfig(String groupName, Map<String, String> configuration); + + /** + * Retrieve recent online records from HMaster / RegionServers. + * Examples include slow/large RPC logs, balancer decisions by master. + * + * @param logRequest request payload with possible filters + * @return Log entries representing online records from servers + */ + CompletableFuture<List<LogEntry>> getLogEntries(LogRequest logRequest); Review comment: Please define a limit parameter for the Admin API. I'm open to other suggestions, but by "individual use cases" I believe you mean the RPC message classes, and those are not user facing public API. The user facing API here is the Admin API. This is the place to do this. As an alternative you can do the same thing as you did for the SlowLog API where a filter can be supplied, and one thing the filter interface lets you do is specify a limit. I won't approve this without a limit option of some kind in the public user facing admin API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org