apurtell commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r482601358
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2472,4 +2482,13 @@ boolean snapshotCleanupSwitch(final boolean on, final
boolean synchronous)
*/
void updateRSGroupConfig(String groupName, Map<String, String>
configuration) throws IOException;
+ /**
+ * Retrieve recent online records from HMaster / RegionServers.
+ * Examples include slow/large RPC logs, balancer decisions by master.
+ *
+ * @param logRequest request payload with possible filters
+ * @return Log entries representing online records from servers
+ * @throws IOException if a remote or network exception occurs
+ */
+ List<LogEntry> getLogEntries(LogRequest logRequest) throws IOException;
Review comment:
Please define a limit parameter for the Admin API. I'm open to other
suggestions, but by "individual use cases" I believe you mean the RPC message
classes, and those are not the user facing API, they are an implementation
detail.
As an alternative you can do the same thing as you did for the SlowLog API
where a filter can be supplied, and one thing the filter interface lets you do
is specify a limit.
I won't approve this without a limit option of some kind in the public user
facing admin API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
