infraio commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r486884181
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
> Reread RpcRetryingCallerImpl#callWithRetries code. If callable.prepare
throw the LockTimeoutException, it will not retry. There are a check about call
duration and callTimeout in line 156.
My point here is that your 15 seconds SLA case is not right. It is still
meet your SLA even you use the operation timeout. I didn't mean that "move
takeUserRegionLock to try catch block". Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
