shahrs87 commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r487273056
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
> Operation timeout is not the best choice too but better
@infraio In scan operation, there are 2 operations. One is to wait for lock
and other is to wait for rpc to complete. On top of that we have retries. The
problem we are trying to solve here is what is the timeout to use for lock. If
we wait for operation timeout period and if it can't get the lock after the
timeout, it will not have any time remaining for next attempts. So I am
confused when you suggest to use operation timeout, are you suggesting to wait
for operation timeout period while trying to get lock ?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you !
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you ! Cc @SukumarMaddineni
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
> Operation timeout is not the best choice too but better
@infraio In scan operation, there are 2 operations. One is to wait for lock
and other is to wait for rpc to complete. On top of that we have retries. The
problem we are trying to solve here is what is the timeout to use for lock. If
we wait for operation timeout period and if it can't get the lock after the
timeout, it will not have any time remaining for next attempts. So I am
confused when you suggest to use operation timeout, are you suggesting to wait
for operation timeout period while trying to get lock ?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you !
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you ! Cc @SukumarMaddineni
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
> Operation timeout is not the best choice too but better
@infraio In scan operation, there are 2 operations. One is to wait for lock
and other is to wait for rpc to complete. On top of that we have retries. The
problem we are trying to solve here is what is the timeout to use for lock. If
we wait for operation timeout period and if it can't get the lock after the
timeout, it will not have any time remaining for next attempts. So I am
confused when you suggest to use operation timeout, are you suggesting to wait
for operation timeout period while trying to get lock ?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you !
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you ! Cc @SukumarMaddineni
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@infraio Thank you for your comment. Now I understand better what you
mean. Let me update the PR by today. Thank you for being so patient with me.
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
> Operation timeout is not the best choice too but better
@infraio In scan operation, there are 2 operations. One is to wait for lock
and other is to wait for rpc to complete. On top of that we have retries. The
problem we are trying to solve here is what is the timeout to use for lock. If
we wait for operation timeout period and if it can't get the lock after the
timeout, it will not have any time remaining for next attempts. So I am
confused when you suggest to use operation timeout, are you suggesting to wait
for operation timeout period while trying to get lock ?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you !
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you ! Cc @SukumarMaddineni
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@infraio Thank you for your comment. Now I understand better what you
mean. Let me update the PR by today. Thank you for being so patient with me.
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
> Operation timeout is not the best choice too but better
@infraio In scan operation, there are 2 operations. One is to wait for lock
and other is to wait for rpc to complete. On top of that we have retries. The
problem we are trying to solve here is what is the timeout to use for lock. If
we wait for operation timeout period and if it can't get the lock after the
timeout, it will not have any time remaining for next attempts. So I am
confused when you suggest to use operation timeout, are you suggesting to wait
for operation timeout period while trying to get lock ?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you !
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you ! Cc @SukumarMaddineni
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@infraio Thank you for your comment. Now I understand better what you
mean. Let me update the PR by today. Thank you for being so patient with me.
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
> Operation timeout is not the best choice too but better
@infraio In scan operation, there are 2 operations. One is to wait for lock
and other is to wait for rpc to complete. On top of that we have retries. The
problem we are trying to solve here is what is the timeout to use for lock. If
we wait for operation timeout period and if it can't get the lock after the
timeout, it will not have any time remaining for next attempts. So I am
confused when you suggest to use operation timeout, are you suggesting to wait
for operation timeout period while trying to get lock ?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you !
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you ! Cc @SukumarMaddineni
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@infraio Thank you for your comment. Now I understand better what you
mean. Let me update the PR by today. Thank you for being so patient with me.
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
> Operation timeout is not the best choice too but better
@infraio In scan operation, there are 2 operations. One is to wait for lock
and other is to wait for rpc to complete. On top of that we have retries. The
problem we are trying to solve here is what is the timeout to use for lock. If
we wait for operation timeout period and if it can't get the lock after the
timeout, it will not have any time remaining for next attempts. So I am
confused when you suggest to use operation timeout, are you suggesting to wait
for operation timeout period while trying to get lock ?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you !
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@saintstack Could you please chime in with your inputs. I think we are
going back and forth on which timeout to use. Also I have created
https://issues.apache.org/jira/browse/HBASE-24983 to wrap the whole scan
operation within operation timeout but is outside the scope of this jira. Thank
you ! Cc @SukumarMaddineni
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
Review comment:
@infraio Thank you for your comment. Now I understand better what you
mean. Let me update the PR by today. Thank you for being so patient with me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
