saintstack commented on a change in pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#discussion_r490690562
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##########
@@ -435,28 +483,60 @@ public void refreshSources(String peerId) throws
IOException {
* @param src source to clear
*/
void removeRecoveredSource(ReplicationSourceInterface src) {
- LOG.info("Done with the recovered queue " + src.getQueueId());
+ LOG.info("Done with recovered replication queue {}", src.getQueueId());
this.oldsources.remove(src);
// Delete queue from storage and memory
- deleteQueue(src.getQueueId());
+ deleteQueue(src);
this.walsByIdRecoveredQueues.remove(src.getQueueId());
}
/**
* Clear the metrics and related replication queue of the specified old
source
- * @param src source to clear
*/
- void removeSource(ReplicationSourceInterface src) {
- LOG.info("Done with the queue " + src.getQueueId());
+ public void removeSource(ReplicationSourceInterface src) {
+ LOG.info("Done with replication queue {}", src.getQueueId());
this.sources.remove(src.getPeerId());
// Delete queue from storage and memory
- deleteQueue(src.getQueueId());
+ deleteQueue(src);
this.walsById.remove(src.getQueueId());
}
/**
- * Delete a complete queue of wals associated with a replication source
- * @param queueId the id of replication queue to delete
+ * Add hbase:meta replication source. Called on open of hbase:meta.
+ * @see #removeHBaseMetaSource()
+ */
+ public ReplicationSourceInterface addHBaseMetaSource() throws IOException {
+ return addSource(new ReplicationPeerImpl(this.server.getConfiguration(),
Review comment:
Changed my mind. Takes current configuration and cluster id so would
need to be made on construction and why create it on all servers when only need
on server carrying hbase:meta.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
