saintstack commented on pull request #2413: URL: https://github.com/apache/hbase/pull/2413#issuecomment-694640598
`And there is also a whole in our implementation is that, when a RS first carries meta region, it will create a WAL for meta region, but once we move meta region out, the WAL will not be closed. I think with your approach in this PR, to add something when assigning/unassigning meta region, we could also clean up the meta WAL? And it could be a separated issue before this PR, to also make this PR smaller.` Oh, this is a good point. So, on open/close of hbase:meta, in the Assign/UnassignRegionHandler, there would be special tasks to run ... e.g. close WALs on close of hbase:meta? I like this. I could break this bit out of this patch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
