ndimiduk commented on a change in pull request #2490:
URL: https://github.com/apache/hbase/pull/2490#discussion_r499912573
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -3003,18 +2933,20 @@ public double getAverageLoad() {
return regionStates.getAverageLoad();
}
- /*
- * @return the count of region split plans executed
+ /**
+ * Exposed here for metrics.
+ * @see RegionNormalizerManager#getSplitPlanCount()
*/
public long getSplitPlanCount() {
- return splitPlanCount;
+ return regionNormalizerManager.getSplitPlanCount();
}
- /*
- * @return the count of region merge plans executed
+ /**
+ * Exposed here for metrics.
+ * @see RegionNormalizerManager#getMergePlanCount()
*/
public long getMergePlanCount() {
- return mergePlanCount;
+ return regionNormalizerManager.getMergePlanCount();
Review comment:
Yeah these are exposed as metrics, all of which hang off of the HMaster
instance. I think it's a larger refactor (and probably backward incompatible)
to move these various metrics down a level in the metric name dotted-path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
