ndimiduk commented on a change in pull request #2490:
URL: https://github.com/apache/hbase/pull/2490#discussion_r499913092
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
##########
@@ -570,8 +569,10 @@ private void preSplitRegion(final MasterProcedureEnv env)
try {
env.getMasterServices().getMasterQuotaManager().onRegionSplit(this.getParentRegion());
} catch (QuotaExceededException e) {
-
env.getMasterServices().getRegionNormalizer().planSkipped(this.getParentRegion(),
- NormalizationPlan.PlanType.SPLIT);
+ // TODO: why is this here? merge requests can be submitted by actors
other than the normalizer
Review comment:
Sorry, this is a copy-paste error in the comment.
I added it because these callbacks seem to me to be only partially
implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
