HorizonNet commented on a change in pull request #2542:
URL: https://github.com/apache/hbase/pull/2542#discussion_r504998610
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -466,13 +466,31 @@
*/
protected String useThisHostnameInstead;
+ /**
+ * @deprecated
Review comment:
Please also add the version when this one was deprecated and in which
release it is going to be removed. Check the [HBase
book](https://hbase.apache.org/book.html#hbase.versioning.post10) for details.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -466,13 +466,31 @@
*/
protected String useThisHostnameInstead;
+ /**
+ * @deprecated
+ * Use {@link
HRegionServer#UNSAFE_RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY} instead.
+ */
+ @Deprecated
+ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
+ final static String DEPRECATED_RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY =
Review comment:
Why not stick with the previous constant name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
