virajjasani commented on a change in pull request #2542:
URL: https://github.com/apache/hbase/pull/2542#discussion_r510983729
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -466,13 +466,31 @@
*/
protected String useThisHostnameInstead;
+ /**
+ * @deprecated
+ * Use {@link
HRegionServer#UNSAFE_RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY} instead.
+ */
+ @Deprecated
+ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
+ final static String DEPRECATED_RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY =
Review comment:
@gvprathyusha6 I think it's fine to stick to
`RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY`. `@ Deprecated` should be enough
here.
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java
##########
@@ -35,13 +35,21 @@
// the specification of server hostname is optional. The hostname should be
resolvable from
// both master and region server
@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
- public static final String RS_HOSTNAME_KEY = "hbase.regionserver.hostname";
+ public static final String UNSAFE_RS_HOSTNAME_KEY =
"hbase.unsafe.regionserver.hostname";
@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
public static final String MASTER_HOSTNAME_KEY = "hbase.master.hostname";
private static boolean HAS_NEW_DNS_GET_DEFAULT_HOST_API;
private static Method GET_DEFAULT_HOST_METHOD;
+ /**
+ * @deprecated since 2.4.0 and in 3.0.0, to be removed in 4.0.0.
+ * Use {@link DNS#UNSAFE_RS_HOSTNAME_KEY} instead.
+ */
+ @Deprecated
+ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
+ public static final String DEPRECATED_RS_HOSTNAME_KEY =
"hbase.unsafe.regionserver.hostname";
Review comment:
Even `UNSAFE_RS_HOSTNAME_KEY` has same value as this one. Maybe you
wanted to change this value to `hbase.regionserver.hostname`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
