z3n3r commented on a change in pull request #2445:
URL: https://github.com/apache/hbase/pull/2445#discussion_r506772362
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MutableRegionInfo.java
##########
@@ -126,7 +127,9 @@ private static int checkReplicaId(int regionId) {
this.replicaId = checkReplicaId(replicaId);
this.offLine = offLine;
this.regionName = RegionInfo.createRegionName(this.tableName,
this.startKey, this.regionId,
- this.replicaId, !this.tableName.equals(TableName.META_TABLE_NAME));
+ this.replicaId,
+ //1 is region id of FIRST_META_REGION_INFO
+ !(this.tableName.equals(TableName.META_TABLE_NAME) && regionId == 1));
Review comment:
Post split meta the region ids will be in the non-legacy format. This
special case here is to handle the primordial meta region which is in legacy
format. So we need to catch if the primordial meta region is being instantiated
here and make sure it is created in the legacy format.
Note I think I need to handle primordial meta region replicas here as well.
(Do I need to support that?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
