z3n3r commented on a change in pull request #2445:
URL: https://github.com/apache/hbase/pull/2445#discussion_r506773341
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -1130,22 +1143,24 @@ public void run(PRESP resp) {
* List all region locations for the specific table.
*/
private CompletableFuture<List<HRegionLocation>>
getTableHRegionLocations(TableName tableName) {
- if (TableName.META_TABLE_NAME.equals(tableName)) {
+ if (ROOT_TABLE_NAME.equals(tableName)) {
CompletableFuture<List<HRegionLocation>> future = new
CompletableFuture<>();
- addListener(connection.registry.getMetaRegionLocations(), (metaRegions,
err) -> {
+ addListener(connection.registry.getMetaRegionLocations(), (rootRegions,
err) -> {
if (err != null) {
future.completeExceptionally(err);
- } else if (metaRegions == null || metaRegions.isEmpty() ||
- metaRegions.getDefaultRegionLocation() == null) {
+ } else if (rootRegions == null || rootRegions.isEmpty() ||
+ rootRegions.getDefaultRegionLocation() == null) {
future.completeExceptionally(new IOException("meta region does not
found"));
} else {
-
future.complete(Collections.singletonList(metaRegions.getDefaultRegionLocation()));
+
future.complete(Collections.singletonList(rootRegions.getDefaultRegionLocation()));
}
});
return future;
} else {
- // For non-meta table, we fetch all locations by scanning hbase:meta
table
- return ClientMetaTableAccessor.getTableHRegionLocations(metaTable,
tableName);
+ // For non-meta table, we fetch all locations by scanning catalog table
Review comment:
Yes this needs updating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
