z3n3r commented on a change in pull request #2445:
URL: https://github.com/apache/hbase/pull/2445#discussion_r506777755
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
##########
@@ -400,28 +419,132 @@ public boolean isTableDisabled(final TableName
tableName) {
}
//
============================================================================================
- // META Helpers
+ // ROOT Helpers
//
============================================================================================
- private boolean isMetaRegion(final RegionInfo regionInfo) {
- return regionInfo.isMetaRegion();
+ private boolean isRootRegion(final RegionInfo regionInfo) {
+ return regionInfo.isRootRegion();
}
- public boolean isMetaRegion(final byte[] regionName) {
- return getMetaRegionFromName(regionName) != null;
+ public boolean isCarryingRoot(final ServerName serverName) {
+ // TODO: handle multiple root
+ return isCarryingRegion(serverName, RegionInfoBuilder.ROOT_REGIONINFO);
}
- public RegionInfo getMetaRegionFromName(final byte[] regionName) {
- for (RegionInfo hri: getMetaRegionSet()) {
- if (Bytes.equals(hri.getRegionName(), regionName)) {
- return hri;
- }
+ private RegionInfo getRootForRegion(final RegionInfo regionInfo) {
+ //if (regionInfo.isRootRegion()) return regionInfo;
+ // TODO: handle multiple root. if the region provided is not root lookup
+ // which root the region belongs to.
+ return RegionInfoBuilder.ROOT_REGIONINFO;
+ }
+
+ /**
+ * Check hbase:root is up and ready for reading. For use during Master
startup only.
+ * @return True if root is UP and online and startup can progress.
Otherwise, root is not online
+ * and we will hold here until operator intervention.
+ */
+ public boolean waitForRootOnline() {
+ return isRegionOnline(RegionInfoBuilder.ROOT_REGIONINFO);
+ }
+
+ private static final Set<RegionInfo> ROOT_REGION_SET =
+ Collections.singleton(RegionInfoBuilder.ROOT_REGIONINFO);
+ public Set<RegionInfo> getRootRegionSet() {
+ return ROOT_REGION_SET;
+ }
+
+ //
============================================================================================
+ // ROOT Event(s) helpers
+ //
============================================================================================
+ /**
+ * Notice that, this only means the root region is available on a RS, but
the AM may still be
+ * loading the region states from root, so usually you need to check {@link
#isRootLoaded()} first
+ * before checking this method, unless you can make sure that your piece of
code can only be
+ * executed after AM builds the region states.
+ * @see #isRootLoaded()
+ */
+ public boolean isRootAssigned() {
+ return rootAssignEvent.isReady();
+ }
+
+ public boolean isRootRegionInTransition() {
+ return !isRootAssigned();
+ }
+
+ /**
+ * Notice that this event does not mean the AM has already finished region
state rebuilding. See
+ * the comment of {@link #isRootAssigned()} for more details.
+ * @see #isRootAssigned()
+ */
+ public boolean waitRootAssigned(Procedure<?> proc, RegionInfo regionInfo) {
+ return
getRootAssignEvent(getRootForRegion(regionInfo)).suspendIfNotReady(proc);
+ }
+
+ private void setRootAssigned(RegionInfo rootRegionInfo, boolean assigned) {
+ assert isRootRegion(rootRegionInfo) : "unexpected non-root region " +
rootRegionInfo;
+ if (!RegionReplicaUtil.isDefaultReplica(rootRegionInfo)) {
+ return;
}
- return null;
+ ProcedureEvent<?> rootAssignEvent = getRootAssignEvent(rootRegionInfo);
+ if (assigned) {
+ LOG.debug("Setting hbase:root region assigned: "+rootRegionInfo);
+ rootAssignEvent.wake(getProcedureScheduler());
+ } else {
+ LOG.debug("Setting hbase:root region unassigned: "+rootRegionInfo);
+ rootAssignEvent.suspend();
+ }
+ }
+
+ private ProcedureEvent<?> getRootAssignEvent(RegionInfo rootRegionInfo) {
+ assert isRootRegion(rootRegionInfo) : "unexpected non-catalog region " +
rootRegionInfo;
+ // TODO: handle multiple root.
Review comment:
Yeah only one root. Thanks for confirming that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
