z3n3r commented on a change in pull request #2445:
URL: https://github.com/apache/hbase/pull/2445#discussion_r506778937
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
##########
@@ -1440,10 +1625,42 @@ private void
handleRegionOverStuckWarningThreshold(final RegionInfo regionInfo)
//
============================================================================================
// TODO: Master load/bootstrap
//
============================================================================================
- public void joinCluster() throws IOException {
+ public void joinCluster(boolean loadRoot) throws IOException {
+ joinCluster(loadRoot, true, true);
+ }
+
+ @VisibleForTesting
+ public void joinCluster(boolean loadRoot, boolean shouldWaitForRootOnline,
+ boolean shouldWaitForMetaOnline)
+ throws IOException {
long startTime = System.nanoTime();
LOG.debug("Joining cluster...");
+ // FIRST Catalog tables READ!!!!
+ // The below cannot make progress w/o hbase:meta being online.
Review comment:
this should talk about loadRoot() and loadMeta(). let me change this to
be more generalized to address both code sections?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
