[GitHub] [hbase] yuqi1129 commented on a change in pull request #2657: HBASE-25282 Remove processingServers in DeadServer as we can get this…

Tue, 17 Nov 2020 01:14:46 -0800 


yuqi1129 commented on a change in pull request #2657:
URL: https://github.com/apache/hbase/pull/2657#discussion_r524994348



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -2440,6 +2440,12 @@ public ClearDeadServersResponse 
clearDeadServers(RpcController controller,
         Set<Address> clearedServers = new HashSet<>();
         for (HBaseProtos.ServerName pbServer : request.getServerNameList()) {
           ServerName server = ProtobufUtil.toServerName(pbServer);
+          final boolean deadInProcess = 
master.getServerManager().isDeadServersInProgress(server);

Review comment:
       See code here
   
![image](https://user-images.githubusercontent.com/15794564/99370140-41732e00-28f8-11eb-8527-620d03a37515.png)
   
    We need to check where region server with special server name is in 
processing, so i add such a method




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to