infraio commented on a change in pull request #2657:
URL: https://github.com/apache/hbase/pull/2657#discussion_r525635251
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -2440,6 +2440,12 @@ public ClearDeadServersResponse
clearDeadServers(RpcController controller,
Set<Address> clearedServers = new HashSet<>();
for (HBaseProtos.ServerName pbServer : request.getServerNameList()) {
ServerName server = ProtobufUtil.toServerName(pbServer);
+ final boolean deadInProcess =
master.getServerManager().isDeadServersInProgress(server);
+
+ if (!deadInProcess) {
+ throw new RuntimeException(String.format("Dead server '%s' is not
'dead' in fact...", server));
+ }
+
if (!deadServer.removeDeadServer(server)) {
Review comment:
You can filter the SCP here too? I thought no need to introduce new
method. Please keep the code simple. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
