virajjasani commented on a change in pull request #2703:
URL: https://github.com/apache/hbase/pull/2703#discussion_r529581776
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##########
@@ -220,17 +218,16 @@ public static boolean splitLogFile(Path walDir,
FileStatus logfile, FileSystem w
Path rootDir = CommonFSUtils.getRootDir(conf);
FileSystem rootFS = rootDir.getFileSystem(conf);
WALSplitter splitter = new WALSplitter(factory, conf, walRootDir, walFS,
rootDir, rootFS);
- final FileStatus[] wals =
+ final List<FileStatus> wals =
SplitLogManager.getFileList(conf, Collections.singletonList(walsDir),
null);
List<Path> splits = new ArrayList<>();
- if (ArrayUtils.isNotEmpty(wals)) {
+ if (CollectionUtils.isNotEmpty(wals)) {
for (FileStatus wal: wals) {
SplitWALResult splitWALResult = splitter.splitWAL(wal, null);
if (splitWALResult.isFinished()) {
WALSplitUtil.archive(wal.getPath(), splitWALResult.isCorrupt(),
archiveDir, walFS, conf);
- if (splitter.outputSink.splits != null) {
- splits.addAll(splitter.outputSink.splits);
- }
+ //splitter.outputSink.splits is mark as final, do not need null check
+ splits.addAll(splitter.outputSink.splits);
Review comment:
Nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
