yuqi1129 commented on a change in pull request #2703:
URL: https://github.com/apache/hbase/pull/2703#discussion_r530067556
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##########
@@ -220,17 +218,16 @@ public static boolean splitLogFile(Path walDir,
FileStatus logfile, FileSystem w
Path rootDir = CommonFSUtils.getRootDir(conf);
FileSystem rootFS = rootDir.getFileSystem(conf);
WALSplitter splitter = new WALSplitter(factory, conf, walRootDir, walFS,
rootDir, rootFS);
- final FileStatus[] wals =
+ final List<FileStatus> wals =
SplitLogManager.getFileList(conf, Collections.singletonList(walsDir),
null);
List<Path> splits = new ArrayList<>();
- if (ArrayUtils.isNotEmpty(wals)) {
+ if (CollectionUtils.isNotEmpty(wals)) {
Review comment:
The logic here: if wals is not (empty or null), we will do the following
loop, so i can't clearly figure out your meaning, could you description it in
detail ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
