[
https://issues.apache.org/jira/browse/HBASE-25359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244183#comment-17244183
]
Michael Stack commented on HBASE-25359:
---------------------------------------
{quote}If we are at a RC step that is not zero, wouldn't this duplicate all
CHANGES.md and RELEASENOTES.md content for the release?
{quote}
We've been though this scenario in the past. There is a bunch of hackery to cut
the previous RC's additions to the CHANGES/RELEASENOTES out before we add in
the yetus generated lists here
[https://github.com/apache/hbase/blob/b26395f3bb9c9ddc809f434ac653b157cee0db9b/dev-support/create-release/release-util.sh#L515]
> create-release scripts releasedocmaker step should be optional
> --------------------------------------------------------------
>
> Key: HBASE-25359
> URL: https://issues.apache.org/jira/browse/HBASE-25359
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Kyle Purtell
> Priority: Major
>
> The create-release scripts assume, when invoking releasedocmaker and
> performing surgery on CHANGES.md and RELEASENOTES.md during the 'tag' stage,
> that the current RC step is RC0. The entirety of the generated CHANGES.md and
> RELEASENOTES.md files are stitched in at the head, just below the ASF notice.
> If we are at a RC step that is not zero, wouldn't this duplicate all
> CHANGES.md and RELEASENOTES.md content for the release? There would be all
> the content added for RC0, then the same content (with delta) added for RC1,
> and so on.
> For this reason the releasedocmaker invocation should itself be optional.
> For RC steps > 0, assume the RM has updated CHANGES.md and RELEASENOTES.md to
> reflect the delta.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
