[
https://issues.apache.org/jira/browse/HBASE-25359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244238#comment-17244238
]
Andrew Kyle Purtell commented on HBASE-25359:
---------------------------------------------
Just to be clear it's not about trust. As RM, I trust the script. However, I
have ... requirements? idiosyncrasies? idiot-syncracies? :-)
One of them is manual update of changes and retagging when incrementing the RC
step. Skipping the 'tag' step totally will meet the objective of this issue but
I thought it worth suggesting breaking it up to be a bit more fine-grained.
This part changes upstream commit history and the RM may want more fine-grained
control over what is happening.
Since we are discussing this, although out of scope for this issue, another
thing I prefer is parallel upload of signed RC artifacts to SVN and the whole
Maven universe including super fat shaded artifacts to the Apache Nexus staging
repository. The way we used to do this in make_rc.sh the deploy build stage is
decoupled from the assembly stage. Assembly artifacts are available before
deploy begins. They _should_ be decoupled. In my experience the upload to Nexus
is bottlenecked somewhere on the Apache side. This is the main reason the build
script takes so long to run. I observed several uploads of artifacts in excess
of 200MB. The total amount of network transfer is on the order of a gigabyte.
> create-release scripts releasedocmaker step should be optional
> --------------------------------------------------------------
>
> Key: HBASE-25359
> URL: https://issues.apache.org/jira/browse/HBASE-25359
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Kyle Purtell
> Priority: Major
>
> The create-release scripts assume, when invoking releasedocmaker and
> performing surgery on CHANGES.md and RELEASENOTES.md during the 'tag' stage,
> that the current RC step is RC0. The entirety of the generated CHANGES.md and
> RELEASENOTES.md files are stitched in at the head, just below the ASF notice.
> If we are at a RC step that is not zero, wouldn't this duplicate all
> CHANGES.md and RELEASENOTES.md content for the release? There would be all
> the content added for RC0, then the same content (with delta) added for RC1,
> and so on.
> For this reason the releasedocmaker invocation should itself be optional.
> For RC steps > 0, assume the RM has updated CHANGES.md and RELEASENOTES.md to
> reflect the delta.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
