infraio commented on a change in pull request #2813:
URL: https://github.com/apache/hbase/pull/2813#discussion_r549953052
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java
##########
@@ -218,50 +220,62 @@ private static Result toResult(HBaseRpcController
controller, MutateResponse res
@Override
public CompletableFuture<Result> get(Get get) {
- return timelineConsistentRead(conn.getLocator(), tableName, get,
get.getRow(),
- RegionLocateType.CURRENT, replicaId -> get(get, replicaId),
readRpcTimeoutNs,
- conn.connConf.getPrimaryCallTimeoutNs(), retryTimer,
conn.getConnectionMetrics());
+ return tracedFuture(
+ () -> timelineConsistentRead(conn.getLocator(), tableName, get,
get.getRow(),
+ RegionLocateType.CURRENT, replicaId -> get(get, replicaId),
readRpcTimeoutNs,
+ conn.connConf.getPrimaryCallTimeoutNs(), retryTimer,
conn.getConnectionMetrics()),
+ "AsyncTable.get", tableName);
+ }
+
+ private String getSpanName(String methodName) {
Review comment:
Typo: getSpanName not used anymore as you use AsyncTable.xxx directly.
LGTM overall.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
