Apache9 commented on a change in pull request #2813:
URL: https://github.com/apache/hbase/pull/2813#discussion_r549539702
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
##########
@@ -203,26 +204,36 @@ public boolean isClosed() {
return closed.get();
}
+ private void closeQuietly(Closeable c) {
Review comment:
The old implementation just suppress the exception without logging. For
guava Closeables, it will never throw IOException if threw is false.
So the suggestion is to upgrade the commons-io and uses the new methods?
Can revert here as it is not a big deal for the PR here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
