[
https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264541#comment-17264541
]
Duo Zhang commented on HBASE-25279:
-----------------------------------
It used to be daemon for a long time until IIRC, [~vjasani] contributed a patch
to make use of guava ThreadFactoryBuilder to replace all the thread pool
creation in HBase, we missed the setDaemon(true) call. This is just a restore
of the old behavior.
For me, I suggest we just restore the old behavior first. And if you think this
a (old) bug, then let's try to fix it, in another issue.
Anyway, you are the release manager, so this depends on you.
> Non-daemon thread in ZKWatcher
> ------------------------------
>
> Key: HBASE-25279
> URL: https://issues.apache.org/jira/browse/HBASE-25279
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons
> which will prevent clean shut downs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
