[
https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264542#comment-17264542
]
Josh Elser commented on HBASE-25279:
------------------------------------
bq. If they are daemonized if the process exits the thread can be terminated
in the middle of updating other state.
My assumption is that a watcher terminating abruptly is no different than
someone doing a {{kill -9}} on one of our processes. So, if a process abruptly
ends, there should already be something which is "fixing" that half-done state
(e.g. a procedure rollback).
That said, you want to leave branch-2.4 in the hung-shutdown state for now
rather than daemonize these and then figure out why they're not being closed
gracefully? I would've expected to get the workaround in place and then revert
the workaround when the lack-of-closure is figured out.
Sorry if I misread the intent from Bharath the first time around.
> Non-daemon thread in ZKWatcher
> ------------------------------
>
> Key: HBASE-25279
> URL: https://issues.apache.org/jira/browse/HBASE-25279
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons
> which will prevent clean shut downs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
