virajjasani commented on pull request #2891: URL: https://github.com/apache/hbase/pull/2891#issuecomment-761742273
> @virajjasani Please correct me if I'm wrong. As part of [HBASE-21588](https://issues.apache.org/jira/browse/HBASE-21588), procedure-based WAL splitting was introduced and was also backported to branch-2.3. However, as part of [HBASE-24632](https://issues.apache.org/jira/browse/HBASE-24632), procedure-based WAL splitting was made as default(on 3.0.0 and 2.4.0) which is why this change is required especially on the other branches(including branch-2.3) so that we explicitly use procedure-based WAL splitting in the tests. I made an incorrect assumption while writing the test that procedure-based splitting is the default way for all branches. @dasanjan1296 your understanding of feature rollout is correct. However, since master and branch-2, 2.4 are the ones with proc based WAL splitting as default, current PR changes should be applied to them. For branch-2.3, ZK based WAL splitting is default but proc based WAL split option is available I believe. Hence, for branch-2.3 test, rather than changing current test file, you can create new one and disable ZK based WAL splitting prop specifically there. That way we will be able to write test only in that new test class without affecting existing one because existing one behaves with default behaviour. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
