dasanjan1296 edited a comment on pull request #2891: URL: https://github.com/apache/hbase/pull/2891#issuecomment-761743811
@virajjasani Thanks a lot for the clarification! However, I still have one concern. In the test file, viz. `TestSplitWALManager.java`, we are already disabling zk-based WAL splitting[[here](https://github.com/apache/hbase/blob/502dc856ba383767c9c06080a74c10cec25eef6a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java#L79)] as part of the common mini-cluster setup in the Test Fixtures. The change in this PR is to disable zk-based splitting only in one Test Case as it requires spawning another mini-cluster. This change shouldn't affect the other tests in the test file and is also in line with the test fixtures. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
