shahrs87 commented on a change in pull request #2943:
URL: https://github.com/apache/hbase/pull/2943#discussion_r573298803



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -148,12 +148,10 @@ public void run() {
           }
         }
       } catch (IOException e) { // stream related
+        LOG.error("Failed to read stream of replication entries", e);

Review comment:
       @wchevreuil  We will log inside handleEofException *only* if the 
exception or cause of exception is an EOF not otherwise. If we make this line 
at debug then we won't see any logs if it is caused by non-eof exception.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to