[GitHub] [hbase] shahrs87 commented on a change in pull request #2943: HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying

[GitBox]

shahrs87 commented on a change in pull request #2943:
URL: https://github.com/apache/hbase/pull/2943#discussion_r578469987



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -148,12 +148,11 @@ public void run() {
           }
         }
       } catch (IOException e) { // stream related
+        if (!handleEofException(e)) {
+          LOG.error("Failed to read stream of replication entries", e);
+        }

Review comment:
       The patch looks good to me too.
   I had one non patch related question. Does it even make sense to sleep if we 
were able to handle eof exception successfully ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org