bharathv commented on a change in pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#discussion_r574098579
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java
##########
@@ -81,15 +82,16 @@ public ExecutorService(final String servername) {
/**
* Start an executor service with a given name. If there was a service
already
* started with the same name, this throws a RuntimeException.
- * @param name Name of the service to start.
+ * @param config Configuration to use for the executor.
*/
- public void startExecutorService(String name, int maxThreads) {
+ public void startExecutorService(final ExecutorConfig config) {
Review comment:
Updated.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java
##########
@@ -182,12 +182,60 @@ public void delayedSubmit(EventHandler eh, long delay,
TimeUnit unit) {
return ret;
}
+ /**
+ * Configuration wrapper for {@link Executor}.
+ */
+ public static class ExecutorConfig {
+ // Refer to ThreadPoolExecutor javadoc for details of these configuration.
+ // Argument validation and bound checks delegated to the underlying
ThreadPoolExecutor
+ // implementation.
Review comment:
@wchevreuil @virajjasani I lost the old comments after a force push. I
think I updated the code to get rid of maxPoolSize which is not honored for
unbounded taskQueue (thanks Wellington)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
