virajjasani commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-779671714
So far, we are starting off with terminating core worker threads if no tasks
arrive in keepAlive time only for EventTypes:
`RS_LOG_REPLAY_OPS`, `RS_PARALLEL_SEEK`, `MASTER_SNAPSHOT_OPERATIONS`,
`MASTER_MERGE_OPERATIONS`. Is that correct? In HMaster#startServiceThreads,
only `MASTER_MERGE_OPERATIONS` has this comment. Let's also add same comment
for other 3 EventTypes?
Also, I might have missed it somewhere, but do we not want to keep
`allowCoreThreadTimeout` as `true` by default? If the core threads are
terminated, and if new task arrives, they are re-initiated right?
```
* Sets the policy governing whether core threads may time out and
* terminate if no tasks arrive within the keep-alive time, being
* replaced if needed when new tasks arrive.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
