shahrs87 commented on a change in pull request #3004:
URL: https://github.com/apache/hbase/pull/3004#discussion_r586350297
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
##########
@@ -470,6 +470,14 @@ public static boolean matchingValue(final Cell left, final
byte[] buf) {
buf.length);
}
+ /*
+ Compares tags in both cells.
+ */
+ public static boolean matchingTags(final Cell left, final Cell right) {
Review comment:
@anoopsjohn Thanks for the review.
I did follow the same convention that
[CellUtil#matchingValue](https://github.com/apache/hbase/blob/branch-1/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java#L463-L466)
does.
```
public static boolean matchingValue(final Cell left, final Cell right) {
return Bytes.equals(left.getValueArray(), left.getValueOffset(),
left.getValueLength(),
right.getValueArray(), right.getValueOffset(),
right.getValueLength());
}
```
> Still better follow what other matchingXXX do
Anoop,
could you please elaborate what you mean ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
