shahrs87 commented on a change in pull request #3004:
URL: https://github.com/apache/hbase/pull/3004#discussion_r586553470



##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
##########
@@ -470,6 +470,14 @@ public static boolean matchingValue(final Cell left, final 
byte[] buf) {
         buf.length);
   }
 
+  /*
+    Compares tags in both cells.
+   */
+  public static boolean matchingTags(final Cell left, final Cell right) {

Review comment:
       Tags are little bit convoluted in master branch. There are 2 
implementation for KeyValue there..one backed by ByteBuffer and other backed by 
Array. We wanted this in our internal branch which is based of branch-1.6 so I 
created first again branch-1. Wanted to get a quick feedback from community 
first.
   
   @anoopsjohn  Will create a PR against master soon.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to