sandeepvinayak commented on a change in pull request #3009:
URL: https://github.com/apache/hbase/pull/3009#discussion_r586729721
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -293,9 +293,12 @@ public void run() {
while (this.isSourceActive() && this.peerClusterId == null) {
this.peerClusterId = replicationEndpoint.getPeerUUID();
if (this.isSourceActive() && this.peerClusterId == null) {
+ metrics.setPeerZkConnectionFailures(false);
Review comment:
Yes, I agree that WARN should be there as well but the metric helps to
monitor and alert in this case. Since connection to peer's ZK blocks the whole
replication, it should be good to monitor this as a metric.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]