brfrn169 commented on a change in pull request #3150:
URL: https://github.com/apache/hbase/pull/3150#discussion_r618040360
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
##########
@@ -110,6 +111,15 @@ public SplitTableRegionProcedure(final MasterProcedureEnv
env,
// we fail-fast on construction. There it skips the split with just a
warning.
checkOnline(env, regionToSplit);
this.bestSplitRow = splitRow;
+ TableDescriptor tableDescriptor =
env.getMasterServices().getTableDescriptors()
+ .get(getTableName());
+ Configuration conf = env.getMasterConfiguration();
+ if (hasBestSplitRow()) {
Review comment:
Yes, that's the behavior of KeyPrefixSplitPolicy, and we will not fix
the split row even if it breaks the rule. And maybe it's not easy to fix it
because RegionSplitPolicy doesn't have any method to restrict/convert a
user-specified split point. It has only `byte[] getSplitPoint()` that gets an
appropriate split point calculated based on its policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
