saintstack commented on a change in pull request #3150:
URL: https://github.com/apache/hbase/pull/3150#discussion_r617189237
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
##########
@@ -110,6 +111,15 @@ public SplitTableRegionProcedure(final MasterProcedureEnv
env,
// we fail-fast on construction. There it skips the split with just a
warning.
checkOnline(env, regionToSplit);
this.bestSplitRow = splitRow;
+ TableDescriptor tableDescriptor =
env.getMasterServices().getTableDescriptors()
+ .get(getTableName());
+ Configuration conf = env.getMasterConfiguration();
+ if (hasBestSplitRow()) {
Review comment:
Good point. So user may be 'surprised' if we do not split where they
want? Will there be a message saying so anywhere that their choice has been
over-ruled by the restriction? Or will it be obvious that the 'restriction'
over-ruled?
I'm good w/ the restriction over-ruling the user as long as there a log to
this effect (add the 'behavior change' to the existing nice release note
@brfrn169 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
