[ https://issues.apache.org/jira/browse/HBASE-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279363#comment-13279363 ]
jirapos...@reviews.apache.org commented on HBASE-6036: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5157/ ----------------------------------------------------------- (Updated 2012-05-19 00:24:57.479662) Review request for hbase and Michael Stack. Changes ------- Update for Stack's comments and latest trunk. Summary ------- Convert the cluster-level calls that do not touch the file-format related calls (see HBASE-5453). These are: IsMasterRunning Shutdown StopMaster Balance LoadBalancerIs (was synchronousBalanceSwitch/balanceSwitch) This addresses bug HBASE-6036. https://issues.apache.org/jira/browse/HBASE-6036 Diffs (updated) ----- src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 007d90b src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 07334f8 src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 80c2165 src/main/java/org/apache/hadoop/hbase/master/HMaster.java a49651b src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java 90cb53d src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java 944e403 src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java dd18ed9 src/main/protobuf/Master.proto PRE-CREATION src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java be52644 src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java 9ff83c5 src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java a24f937 Diff: https://reviews.apache.org/r/5157/diff Testing ------- Ran unit tests, all passed. Thanks, Gregory > Add Cluster-level PB-based calls to HMasterInterface (minus file-format > related calls) > -------------------------------------------------------------------------------------- > > Key: HBASE-6036 > URL: https://issues.apache.org/jira/browse/HBASE-6036 > Project: HBase > Issue Type: Task > Components: ipc, master, migration > Reporter: Gregory Chanan > Assignee: Gregory Chanan > Fix For: 0.96.0 > > Attachments: HBASE-6036.patch > > > This should be a subtask of HBASE-5445, but since that is a subtask, I can't > also make this a subtask (apparently). > Convert the cluster-level calls that do not touch the file-format related > calls (see HBASE-5453). These are: > IsMasterRunning > Shutdown > StopMaster > Balance > LoadBalancerIs (was synchronousBalanceSwitch/balanceSwitch) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira