[
https://issues.apache.org/jira/browse/HBASE-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279367#comment-13279367
]
jirapos...@reviews.apache.org commented on HBASE-6036:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5157/#review7985
-----------------------------------------------------------
src/main/protobuf/Master.proto
<https://reviews.apache.org/r/5157/#comment17347>
BalancerSwitchRequest, balancerSwitch the method name?
Do whatever you think G. I'm not going to hold up the patch over this
naming.
- Michael
On 2012-05-19 00:24:57, Gregory Chanan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5157/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-19 00:24:57)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Convert the cluster-level calls that do not touch the file-format related
calls (see HBASE-5453). These are:
bq. IsMasterRunning
bq. Shutdown
bq. StopMaster
bq. Balance
bq. LoadBalancerIs (was synchronousBalanceSwitch/balanceSwitch)
bq.
bq.
bq. This addresses bug HBASE-6036.
bq. https://issues.apache.org/jira/browse/HBASE-6036
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 007d90b
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
07334f8
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 80c2165
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java a49651b
bq. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
90cb53d
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
944e403
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java dd18ed9
bq. src/main/protobuf/Master.proto PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java be52644
bq.
src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java
9ff83c5
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
a24f937
bq.
bq. Diff: https://reviews.apache.org/r/5157/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran unit tests, all passed.
bq.
bq.
bq. Thanks,
bq.
bq. Gregory
bq.
bq.
> Add Cluster-level PB-based calls to HMasterInterface (minus file-format
> related calls)
> --------------------------------------------------------------------------------------
>
> Key: HBASE-6036
> URL: https://issues.apache.org/jira/browse/HBASE-6036
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6036.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't
> also make this a subtask (apparently).
> Convert the cluster-level calls that do not touch the file-format related
> calls (see HBASE-5453). These are:
> IsMasterRunning
> Shutdown
> StopMaster
> Balance
> LoadBalancerIs (was synchronousBalanceSwitch/balanceSwitch)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
