apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r628956646
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##########
@@ -220,6 +223,8 @@ public ByteString compress(byte[] data, Enum dictIndex) {
}
}
+ static final int VALUE_COMPRESS_THRESHOLD = 100;
Review comment:
Based on my experimentation, zlib will compress a buffer of 100 bytes
filled with zeros to 14 bytes. If we go by powers of 10, 100 seems fine, 10
seems not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
