Apache9 commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-836045614


   So we will only compress value?
   
   As we will do batching when writing WAL entries out, is it possible to 
compress when flushing? The data will be larger and compress may perform 
better. The structure of a WAL file will be multiple compressed blocks.
   
   I think for AsyncFSWAL this is easy as we will buffer all the entries in 
memory and when flush is called we flush all the in memory data out. For FSHLog 
it will be a bit hard as we rely on the DFSOutputStream to do flush if the data 
is too big before we actually call hflush.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to