ndimiduk commented on a change in pull request #3249:
URL: https://github.com/apache/hbase/pull/3249#discussion_r629567327
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1601,6 +1601,89 @@
*/
public static final int BATCH_ROWS_THRESHOLD_DEFAULT = 5000;
+ /**
+ * @deprecated since 2.4.0 and will be removed in 4.0.0.
+ * Use {@link HConstants#UNSAFE_RS_HOSTNAME_KEY} instead.
+ * @see <a
href="https://issues.apache.org/jira/browse/HBASE-24667";>HBASE-24667</a>
+ */
+ @Deprecated
+ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
+ public static final String RS_HOSTNAME_KEY = "hbase.regionserver.hostname";
Review comment:
There's no reason to add all these constants to this `HConstants` class;
it's better if we don't expand our public interface if we can avoid it. I think
it would be better to use the configuration string values directly in the new
`HBaseConfiguration#addDeprecatedKeys()`.
Please do preserve the comments about removal target release.
##########
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/io/TestByteBuffAllocator.java
##########
@@ -18,6 +18,12 @@
package org.apache.hadoop.hbase.io;
+import static org.apache.hadoop.hbase.HConstants.ALLOCATOR_POOL_ENABLED_KEY;
Review comment:
My above suggestion would mean that these symbols simply don't exist
anymore for tests to make use of. I think this is preferable, if test's make
use of the "public" api of the product, not the classes. This way, if a
configuration key is changed in the class, and that configuration key is used
by value in the test, the test would presumably fail.
So in this case, the test will define new constants that contain these
configuration key strings.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobConstants.java
##########
@@ -40,8 +40,7 @@
public static final String MOB_DIR_NAME = "mobdir";
public static final String MOB_REGION_NAME = ".mob";
public static final byte[] MOB_REGION_NAME_BYTES =
Bytes.toBytes(MOB_REGION_NAME);
- public static final String MOB_CLEANER_PERIOD =
"hbase.master.mob.cleaner.period";
Review comment:
Unfortunately this class in `InterfaceAudience.Public`, so these symbols
cannot change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
