saintstack commented on a change in pull request #3249:
URL: https://github.com/apache/hbase/pull/3249#discussion_r629734904
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1601,6 +1601,89 @@
*/
public static final int BATCH_ROWS_THRESHOLD_DEFAULT = 5000;
+ /**
+ * @deprecated since 2.4.0 and will be removed in 4.0.0.
+ * Use {@link HConstants#UNSAFE_RS_HOSTNAME_KEY} instead.
+ * @see <a
href="https://issues.apache.org/jira/browse/HBASE-24667";>HBASE-24667</a>
+ */
+ @Deprecated
+ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
+ public static final String RS_HOSTNAME_KEY = "hbase.regionserver.hostname";
Review comment:
I agree w/ the Nick comment.
This file of all the constants is a bit of an anti-pattern... should have
gone away long ago.... Was hoping it would shrivel but it hasn't. Don't pour
water on it (smile).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
