apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r634837582
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##########
@@ -256,20 +264,31 @@ public void write(Cell cell) throws IOException {
}
}
}
+
+ private void writeCompressedValue(OutputStream out, Cell cell) throws
IOException {
+ byte[] compressed =
compression.getValueCompressor().compress(cell.getValueArray(),
+ cell.getValueOffset(), cell.getValueLength());
+ StreamUtils.writeRawVInt32(out, compressed.length);
+ out.write(compressed);
+ }
+
}
static class CompressedKvDecoder extends BaseDecoder {
private final CompressionContext compression;
+ private final boolean hasValueCompression;
+ private final boolean hasTagCompression;
public CompressedKvDecoder(InputStream in, CompressionContext compression)
{
super(in);
this.compression = compression;
+ this.hasValueCompression = compression.hasValueCompression();
+ this.hasTagCompression = compression.hasTagCompression();
}
@Override
protected Cell parseCell() throws IOException {
Review comment:
No, compression is not supported in `SecureWALCellCodec`.
This is documented. You can have either compression or encryption, but not
both. I'm sure this limitation can be addressed but would be separate follow up
work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
