apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r634838171
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
##########
@@ -70,18 +150,55 @@ public CompressionContext(Class<? extends Dictionary>
dictType, boolean recovere
if (hasTagCompression) {
tagCompressionContext = new TagCompressionContext(dictType,
Short.MAX_VALUE);
}
+ if (hasValueCompression && valueCompressionType != null) {
+ valueCompressor = new ValueCompressor(valueCompressionType);
+ }
+ }
+
+ public CompressionContext(Class<? extends Dictionary> dictType, boolean
recoveredEdits,
+ boolean hasTagCompression)
+ throws SecurityException, NoSuchMethodException, InstantiationException,
+ IllegalAccessException, InvocationTargetException, IOException {
+ this(dictType, recoveredEdits, hasTagCompression, false, null);
+ }
+
+ public boolean hasTagCompression() {
+ return tagCompressionContext != null;
+ }
+
+ public boolean hasValueCompression() {
+ return valueCompressor != null;
}
- public Dictionary getDictionary(Enum dictIndex) {
+ public Dictionary getDictionary(Enum<DictionaryIndex> dictIndex) {
Review comment:
I cannot do this without a ripple effect through WALCodec, which is
LimitedPrivate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
